From: Olivier Fourdan <ofourdan@redhat.com>
Date: Wed, 7 Sep 2016 11:25:24 +0000 (+0200)
Subject: systray: Bail out if the plug window is gone
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~739
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=0b6c5b462012d212df6b25b2d3a2002bbb22f428;p=gnome-shell.git

systray: Bail out if the plug window is gone

Instead of crashing when deferencing a NULL pointer.

Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=755313
---

diff --git a/src/shell-tray-icon.c b/src/shell-tray-icon.c
index 2397117c7..e80dd3e5e 100644
--- a/src/shell-tray-icon.c
+++ b/src/shell-tray-icon.c
@@ -204,6 +204,12 @@ shell_tray_icon_click (ShellTrayIcon *icon,
   gdk_error_trap_push ();
 
   remote_window = gtk_socket_get_plug_window (GTK_SOCKET (icon->priv->socket));
+  if (remote_window == NULL)
+    {
+      g_warning ("shell tray: plug window is gone");
+      gdk_error_trap_pop_ignored ();
+      return;
+    }
   xwindow = GDK_WINDOW_XID (remote_window);
   xdisplay = GDK_WINDOW_XDISPLAY (remote_window);
   screen = gdk_window_get_screen (remote_window);